This repository was archived by the owner on Sep 28, 2022. It is now read-only.
Batch csv #130
Open
Batch csv #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves most of the CSV logic out of cmd/picsv and into csv package. refactor to be a bit cleaner and get ready to handle multiple sources of CSV data.
tgruben
previously approved these changes
Sep 30, 2019
| return batch, pc, nil | ||
| } | ||
|
|
||
| func openFileOrURL(name string) (io.ReadCloser, error) { |
There was a problem hiding this comment.
Its probably not worth the effort but,It would be nice if we provided a more generic storage interface to the various storage interfaces, kinda like https://github.com/kahing/goofys.
|
|
||
| type SourceField struct { | ||
| // TargetField is the Pilosa field that this source field should map to. | ||
| TargetField string `json:"target-field"` |
There was a problem hiding this comment.
Minor: TargetFieldName would provide a little clarity. For some reason Seeing SourceField and TargetField together in the code made me focus on the fact that those are not the same type. Or alternatively SourceFieldArgs?
remove unnecessary OptFieldTypeBool()s
to command main instead of having on PDK main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add picsv command for importing CSV data using the experimental batch ingestion interface