fix: resolve subfolder wiki links on Windows - #493
Open
zacharywomack8-source wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #274
On Windows, \diff_paths\ produces native backslash separators, so a file at \�ault/subfolder/file.md\ got the refname path \subfolder\file. Link text always uses forward slashes ([[subfolder/file]]), so \matches_path_or_file\ compared \subfolder/file\ against \subfolder\file\ and never matched -- causing false "Unresolved Reference" diagnostics and broken go-to-definition for any link into a subfolder. Linux/macOS were unaffected, which matches the reports: reproducible on Windows (see comments) but not on NixOS.
This normalizes refname paths to forward slashes in \get_obsidian_ref_path\ (the single source of refnames for diagnostics, go-to-definition, completions, backlinks), makes \link_file_key\ separator-agnostic, and defensively normalizes in \matches_path_or_file.
Verified:
/claim #274
Generated by Agent Core