fix(windows): preserve image validation stderr - #115
Closed
nightt5879 wants to merge 1 commit into
Closed
Conversation
nightt5879
marked this pull request as ready for review
July 17, 2026 09:25
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Invoke-DreamSkinNativecompatibility wrapper instead of invoking Node with a direct2>&1redirection.Root cause / 根因
Windows PowerShell 5.1 promotes redirected native stderr to
ErrorRecordobjects. With$ErrorActionPreference = 'Stop', the direct image-helper invocation could terminate on its first stderr line before reading$LASTEXITCODE, bypassing the repository's native-command compatibility layer and its stable validation message.Type / 类型
Platform / 平台
Self-check / 自测
Check what you actually ran. Skip items that do not apply and say so under Notes.
请勾选实际跑过的项;不适用的在 Notes 说明。
Docs-only / 仅文档
macOS (when code under
macos/changes)macos/tests/run-tests.shpassed / 已通过macos/scripts/doctor-macos.shverify-dream-skin-macos.shor Desktop VerifyWindows (when code under
windows/changes)install/start/verify/restorescripts exercised / 已按改动跑过对应脚本User-facing / 用户可见变更
macos/CHANGELOG.md(andmacos/VERSIONif release-worthy) / 已更新 changelog(发版时再 bump VERSION)Security / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
powershell.exe -NoProfile -ExecutionPolicy Bypass -File .\windows\tests\run-tests.ps1.data:preload to emit stderr under$ErrorActionPreference = 'Stop'; a valid image still parses, while an invalid image returns the friendlyImage metadata is invalid or exceeds...error rather thanNativeCommandError.git diff --check.windows/CHANGELOG.md; the template's changelog checkbox is macOS-specific.Fixes #112