fix(theme): preserve native side-panel controls - #79
Conversation
48e73ff to
d5d7112
Compare
|
Maintainer update: rebased the original contributor commit onto current Local macOS and Windows Node regressions (8/8), both payload checks, shell syntax, and |
Fei-Away
left a comment
There was a problem hiding this comment.
The root cause and scope are sound: preserve Codex’s native fixed header geometry, exclude that header from the macOS task-child positioning rule, and leave main-surface overflow unchanged. The contributor supplied a real Windows reproduction (toggle x=1568 before, x=1258 after) and repeated open/close validation. Current static checks and both Windows PowerShell suites are green.
|
Final validation on current |
Summary / 摘要
positionandz-indexso the task side-panel toggle stays inside the viewport and clickable.position: relative.Root cause: the theme's more-specific header rule replaced Codex's native
fixed z-30geometry withposition: relativeand a lower stacking level. Opening the right task panel then narrowed the main surface and could push or clip the native toggle outside the viewport.Related: #64 was opened while this fix was in progress. This draft is a cross-platform, narrower alternative: it also preserves the native z-index, leaves
main.main-surfaceoverflow unchanged, and covers the equivalent macOS selector.Type / 类型
Platform / 平台
Self-check / 自测
Docs-only / 仅文档
macOS (when code under
macos/changes)macos/tests/run-tests.shpassed / 已通过macos/scripts/doctor-macos.shverify-dream-skin-macos.shor Desktop VerifyWindows (when code under
windows/changes)install/start/verify/restorescripts exercised / 已按改动跑过对应脚本User-facing / 用户可见变更
macos/CHANGELOG.md(andmacos/VERSIONif release-worthy) / 已更新 changelog(发版时再 bump VERSION)Security / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
overflow: hiddenrule remained unchanged.*.test.mjsfiles, Windows injector--self-testand--check-payload, and the macOS image-metadata, injector-bootstrap, and renderer-inject tests.node --checkfor both renderer payloads.macos/tests/run-tests.shand macOS live verify require a macOS runner and were not run on this Windows host.-File; a forced-UTF-8 harness progressed to the existing native-stderr capture assertion. The focused renderer and injector tests above passed.