fix(macos): allow no-write installs with multiline TOML - #90
Closed
rwang23 wants to merge 1 commit into
Closed
Conversation
rwang23
marked this pull request as ready for review
July 17, 2026 07:12
rwang23
force-pushed
the
fix/macos-multiline-toml-install
branch
from
July 17, 2026 22:04
5e3d408 to
a9028b3
Compare
Owner
|
Closing this old patch without merging it. The underlying compatibility report remains tracked in #67, but current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
中文
config.toml任意位置出现多行字符串、多行数组或重复表头时无条件退出的问题。null,安装不会写入配置。脚本现在先完成严格 UTF-8、NUL 和普通文件校验;确认没有计划写入后,直接保留原文件,也不创建无用备份。args、多行字符串、重复[desktop]、现有备份保留、旧备份恢复、无效 UTF-8、NUL 和符号链接。English
config.tomlcontains a multiline string, multiline array, or duplicate table header.null, so install has no configuration write to perform. The script now completes strict UTF-8, NUL, and regular-file validation, then returns before structural TOML parsing and backup creation when no write is planned.args, multiline strings, duplicate[desktop]tables, backup preservation, legacy restore, invalid UTF-8, NUL, and symbolic links.Closes #67
Type / 类型
Platform / 平台
Self-check / 自测
Docs-only / 仅文档
macOS (when code under
macos/changes)macos/tests/run-tests.shpassed / 已通过macos/scripts/doctor-macos.shverify-dream-skin-macos.shor Desktop VerifyWindows (when code under
windows/changes)install/start/verify/restorescripts exercised / 已按改动跑过对应脚本User-facing / 用户可见变更
macos/CHANGELOG.md(andmacos/VERSIONif release-worthy) / 已更新 changelog(发版时再 bump VERSION)Security / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
中文
node --check macos/scripts/theme-config.mjs:通过。git diff --check:通过。macos/tests/run-tests.sh中的配置回归区段:通过。覆盖无写入安装、无备份恢复、旧备份恢复、备份保留、多行 TOML、中文、无效 UTF-8、NUL 与符号链接。node:24-bookworm-slim中运行完整入口时,Shell 语法、图像元数据、注入启动、渲染器和主题暂存测试通过。随后镜像里的 GNUstat不支持 macOS 的/usr/bin/stat -f '%z',因此没有勾选完整套件。English
node --check macos/scripts/theme-config.mjs: passed.git diff --check: passed.macos/tests/run-tests.shpassed. It covers no-write install, restore without a backup, legacy restore, backup preservation, multiline TOML, Chinese text, invalid UTF-8, NUL, and symbolic links.node:24-bookworm-slim. The image then reached a GNUstatincompatibility with macOS/usr/bin/stat -f '%z', so the full-suite checkbox remains unchecked.