Minor fixes for Mac OS X #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libiconv shipping with Mac OS X doesn't have required symbols. Library search path might have to be adjusted to link with the correct/newer libiconv.
It's not acceptable to change meanings of keywords. If you need a special `noexcept`, define your own macro that expands to either `noexcept` or nothing.
|
Hi Ismail,
many thanks for finding a solution with clang and for the PR!
Since my goal was to minimise the requirements, I wanted to avoid that everybody has to build it's own compiler.
So I did not merge the PR, but I added a link to your branch to the READEME.md as an alternative approach.
I hope you understand and best regards,
Felix
… On 16 April 2017 at 18:41 Ismail Pazarbasi ***@***.***> wrote:
Hi Felix,
thank you for sharing the material. I've got it compiled on Mac with native clang, and a ToT clang build. Users may want to change library search path to find correct libiconv. I use MacPorts, not homebrew, and mine is in /opt/local/lib. After fixing the library search path, it links and works (shows a window).
You can view, comment on, or merge this pull request online at:
#1
-- Commit Summary --
* Don't use libstdc++
* Link with iconv
* Don't mess with the language keywords
* Include `<locale>`
* Include `<clocale>`
-- File Changes --
M nana/CMakeLists.txt (13)
M nana/include/nana/c++defines.hpp (2)
M nana/source/charset.cpp (1)
M nana/source/detail/platform_spec_posix.cpp (1)
-- Patch Links --
https://github.com/FelixPetriconi/accu2017setup/pull/1.patch
https://github.com/FelixPetriconi/accu2017setup/pull/1.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1
|
|
Sure, no problem! I did that, because I didn't want to build gcc, use homebrew, or Linux in a VM. Have a great day, and best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Felix,
thank you for sharing the material. I've got it compiled on Mac with native clang, and a ToT clang build. Users may want to change library search path to find correct libiconv. I use MacPorts, not homebrew, and mine is in /opt/local/lib. After fixing the library search path, it links and works (shows a window).