Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements write and insert operations for ExcelLoader to support writing Excel files using Spark DataFrames. The implementation fills in previously unimplemented methods (marked with ???) and upgrades the spark-excel dependency to a more actively maintained version.
Changes:
- Implemented
write,writeOnce, andinsertmethods in ExcelLoader using Spark's SaveMode.Overwrite and SaveMode.Append - Integrated ExcelLoader with LoadResolver for OverWrite and Insert load types
- Upgraded spark-excel dependency from "com.crealytics" to "dev.mauch" (version 3.5.5_0.30.2)
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala | Implements write, writeOnce, and insert methods with schema validation |
| datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/LoadResolver.scala | Adds EXCEL format support for OverWrite and Insert load types |
| datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala | Adds comprehensive test coverage for write and insert operations with cleanup utilities |
| build.sbt | Updates spark-excel dependency to newer maintained fork |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala
Outdated
Show resolved
Hide resolved
… required by spark-excel
laurabegin
requested changes
Feb 27, 2026
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
laurabegin
requested changes
Mar 4, 2026
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala
Outdated
Show resolved
Hide resolved
laurabegin
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.