Skip to content

feat: UNIC-1977 Implement write and insert for ExcelLoader#285

Merged
Asciax merged 6 commits intomasterfrom
UNIC-1977
Mar 4, 2026
Merged

feat: UNIC-1977 Implement write and insert for ExcelLoader#285
Asciax merged 6 commits intomasterfrom
UNIC-1977

Conversation

@Asciax
Copy link
Copy Markdown
Contributor

@Asciax Asciax commented Feb 26, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements write and insert operations for ExcelLoader to support writing Excel files using Spark DataFrames. The implementation fills in previously unimplemented methods (marked with ???) and upgrades the spark-excel dependency to a more actively maintained version.

Changes:

  • Implemented write, writeOnce, and insert methods in ExcelLoader using Spark's SaveMode.Overwrite and SaveMode.Append
  • Integrated ExcelLoader with LoadResolver for OverWrite and Insert load types
  • Upgraded spark-excel dependency from "com.crealytics" to "dev.mauch" (version 3.5.5_0.30.2)

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File Description
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/ExcelLoader.scala Implements write, writeOnce, and insert methods with schema validation
datalake-spark3/src/main/scala/bio/ferlab/datalake/spark3/loader/LoadResolver.scala Adds EXCEL format support for OverWrite and Insert load types
datalake-spark3/src/test/scala/bio/ferlab/datalake/spark3/loader/ExcelLoaderSpec.scala Adds comprehensive test coverage for write and insert operations with cleanup utilities
build.sbt Updates spark-excel dependency to newer maintained fork

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Asciax Asciax merged commit eadbf84 into master Mar 4, 2026
1 check passed
@Asciax Asciax deleted the UNIC-1977 branch March 4, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants