feat(DeltaUtils): UNIC-2021 Overload stat methods to accept a pre-computed statsDf#287
Merged
laurabegin merged 1 commit intomasterfrom Apr 8, 2026
Merged
feat(DeltaUtils): UNIC-2021 Overload stat methods to accept a pre-computed statsDf#287laurabegin merged 1 commit intomasterfrom
laurabegin merged 1 commit intomasterfrom
Conversation
…omputed statsDf Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Looks like a solid refactor, but I want to double-check how these methods are used in unic-etl before approving, just to make sure nothing breaks downstream.Good for me |
AhmedSabsabi
approved these changes
Apr 8, 2026
Member
Author
|
@AhmedSabsabi FYI we use a pinned version in unic-etl so nothing will break by merging this. I will be able to deploy a new datalake-lib version, then update it in unic-etl and test the changes in unic-etl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataFrameoverloads for allDeltaUtilsstat methods that previously only accepted apath: Stringpathversions now delegate to thestatsDfoverloads, so callers that already have a snapshot fromgetTableStatscan pass it directly and avoid re-reading the Delta loggetPartitionValues,getNumRecords,getNumRecordsPerPartition,getMinValues,getMinValuesPerPartition,getMaxValues,getMaxValuesPerPartition,getNullCounts,getNullCountsPerPartitionMotivation
QA tests in
unic-etlwere callinggetTableStatsmultiple times per dataset (once for ahasStatsprobe, then again inside each stat function). This caused redundant Delta log reads from Minio and a cascade of stuck Spark jobs. The new overloads allow callers to read the snapshot once and reuse it.Test plan
DeltaUtilsSpectests passpathoverloads still behave identically (they delegate to the newstatsDfoverloads)🤖 Generated with Claude Code