fix(scenarios): make Synapse source runs consumer-equivalent - #185
Merged
Conversation
rvagg
commented
Aug 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Synapse source scenarios to use production and peer dependencies under its pnpm policy, and adds EIP-2612 support to MockUSDFC.
Changes:
- Separates source and peer dependency installation.
- Adds source-aware peer resolution.
- Adds and tests ERC20Permit support.
- Updates scenario tests and CI documentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
scripts/tests/test_scenario_dependencies.py |
Updates dependency installation tests. |
scenarios/synapse-e2e/source-runtime.mjs |
Resolves source exports and peer dependencies. |
scenarios/synapse_runtime.py |
Prepares production and peer runtime dependencies. |
contracts/MockUSDFC/test/MockUSDFC.t.sol |
Tests permit functionality. |
contracts/MockUSDFC/src/MockUSDFC.sol |
Adds ERC20Permit support. |
ci/README.md |
Updates dependency installation documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
added pkg.pr.new support in here, deleted a bunch of code in the process 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install only the production dependency closure and resolve peers under Synapse's pnpm security policy. Add EIP-2612 support to MockUSDFC so fresh devnet accounts can fund uploads through Synapse.
#182 didn't quite work in resolving #179