Fix endorsed & approved provider ID fetching discrepancies - #712
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | a94b19c | Commit Preview URL Branch Preview URL |
Apr 02 2026, 03:40 PM |
rvagg
reviewed
Apr 2, 2026
rvagg
reviewed
Apr 2, 2026
rvagg
reviewed
Apr 2, 2026
rvagg
reviewed
Apr 2, 2026
rvagg
approved these changes
Apr 2, 2026
rvagg
left a comment
rvagg
left a comment
Collaborator
There was a problem hiding this comment.
minor suggestions inline, the mutation one being the biggest but also the doc discrepancies
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
juliangruber
approved these changes
Apr 2, 2026
juliangruber
left a comment
juliangruber
left a comment
Member
There was a problem hiding this comment.
+1 and +1 to all of Rod's suggestions
hugomrdias
force-pushed
the
hugomrdias/644
branch
from
April 2, 2026 13:11
699f43b to
a907edd
Compare
…dProviders to getApprovedProvidersIds
hugomrdias
force-pushed
the
hugomrdias/644
branch
2 times, most recently
from
April 2, 2026 14:00
0055c41 to
ca49b1b
Compare
…ate related imports
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org> Update packages/synapse-core/test/get-provider-ids.test.ts Co-authored-by: Rod Vagg <rod@vagg.org> Update packages/synapse-core/src/endorsements/get-endorsed-provider-ids.ts Co-authored-by: Rod Vagg <rod@vagg.org>
hugomrdias
force-pushed
the
hugomrdias/644
branch
from
April 2, 2026 14:02
ca49b1b to
a94b19c
Compare
juliangruber
changed the title
anjor
added a commit
to anjor/pynapse
that referenced
this pull request
Apr 18, 2026
…vider_ids, add get_endorsed_provider_ids Mirrors FilOzone/synapse-sdk#712. - Renames the approved-providers accessor to get_approved_provider_ids (the previous name was misleading — it returns IDs, not full provider records). The method still takes the same offset/limit pagination args. The redundant no-arg wrapper is removed. - Adds get_endorsed_provider_ids(), which reads the ProviderIdSet contract (chain.contracts.provider_id_set) and deduplicates results while preserving insertion order. - Threads a new provider_id_set address through ChainContracts for both mainnet and calibration (already present in ADDRESSES). Breaking: callers of get_approved_providers() must switch to get_approved_provider_ids().
1 task
anjor
added a commit
to anjor/pynapse
that referenced
this pull request
Apr 18, 2026
…vider_ids, add get_endorsed_provider_ids (#25) Mirrors FilOzone/synapse-sdk#712. - Renames the approved-providers accessor to get_approved_provider_ids (the previous name was misleading — it returns IDs, not full provider records). The method still takes the same offset/limit pagination args. The redundant no-arg wrapper is removed. - Adds get_endorsed_provider_ids(), which reads the ProviderIdSet contract (chain.contracts.provider_id_set) and deduplicates results while preserving insertion order. - Threads a new provider_id_set address through ChainContracts for both mainnet and calibration (already present in ADDRESSES). Breaking: callers of get_approved_providers() must switch to get_approved_provider_ids().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getEndorsedProviderIdsgetApprovedProviderIdsgetEndorsedProviderIdsreturn type tobigint[]closes #644