feat!: remove piece metadata getters - #936
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | a6b66bd | Commit Preview URL Branch Preview URL |
Aug 26 2026, 11:47 AM |
Contributor
This is the commit: FilOzone/filecoin-services@4cbbea4 it would be done by automated workflow but the job fails due to the metadata |
hugomrdias
marked this pull request as ready for review
August 25, 2026 14:33
hugomrdias
requested review from
a team,
BigLep,
jennijuju,
rjan90 and
rvagg
as code owners
August 25, 2026 14:33
hugomrdias
requested review from
SgtPooki
and removed request for
a team,
jennijuju and
rjan90
August 25, 2026 14:33
SgtPooki
approved these changes
Aug 25, 2026
SgtPooki
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but fix PR title and comment message cause this is a breaking change.
Also some merge conflicts.
rvagg
reviewed
Aug 26, 2026
rvagg
approved these changes
Aug 26, 2026
hugomrdias
force-pushed
the
hugomrdias/remove-piece-metadata-getters
branch
from
August 26, 2026 11:34
974a475 to
3148c15
Compare
commit: |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PieceAddedevents or an indexerFollow-up required
filecoin-servicescommit is available, updateFILECOIN_SERVICES_GIT_REFinpackages/synapse-core/wagmi.config.tsand runpnpm --dir packages/synapse-core run generate-abi.Testing
pnpm testpnpm run buildpnpm --dir examples/cli run lintpnpm run check:markdownpnpm --dir docs exec astro build