Skip to content

feat!: remove piece metadata getters - #936

Merged
hugomrdias merged 4 commits into
masterfrom
hugomrdias/remove-piece-metadata-getters
Aug 26, 2026
Merged

feat!: remove piece metadata getters#936
hugomrdias merged 4 commits into
masterfrom
hugomrdias/remove-piece-metadata-getters

Conversation

@hugomrdias

@hugomrdias hugomrdias commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove FWSS piece metadata getter APIs and related types
  • Update SDK, core, React hooks, CLI, mocks, and generated ABI handling
  • Document reading piece metadata from PieceAdded events or an indexer
  • Update the Synapse React example for pieces without on-chain metadata

Follow-up required

  • Once the new filecoin-services commit is available, update FILECOIN_SERVICES_GIT_REF in packages/synapse-core/wagmi.config.ts and run pnpm --dir packages/synapse-core run generate-abi.

Testing

  • pnpm test
  • pnpm run build
  • pnpm --dir examples/cli run lint
  • pnpm run check:markdown
  • pnpm --dir docs exec astro build

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Aug 24, 2026
@hugomrdias hugomrdias self-assigned this Aug 24, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 24, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
synapse-dev a6b66bd Commit Preview URL

Branch Preview URL
Aug 26 2026, 11:47 AM

@BigLep BigLep moved this from 📌 Triage to ⌨️ In Progress in FOC Aug 24, 2026
@Kubuxu

Kubuxu commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Once the new filecoin-services commit is available, update FILECOIN_SERVICES_GIT_REF in packages/synapse-core/wagmi.config.ts and run pnpm --dir packages/synapse-core run generate-abi.

This is the commit: FilOzone/filecoin-services@4cbbea4

it would be done by automated workflow but the job fails due to the metadata

@hugomrdias
hugomrdias marked this pull request as ready for review August 25, 2026 14:33
@hugomrdias
hugomrdias requested review from a team, BigLep, jennijuju, rjan90 and rvagg as code owners August 25, 2026 14:33
@hugomrdias
hugomrdias requested review from SgtPooki and removed request for a team, jennijuju and rjan90 August 25, 2026 14:33
@hugomrdias hugomrdias linked an issue Aug 25, 2026 that may be closed by this pull request

@SgtPooki SgtPooki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but fix PR title and comment message cause this is a breaking change.

Also some merge conflicts.

@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FOC Aug 25, 2026
Comment thread packages/synapse-core/wagmi.config.ts Outdated
@hugomrdias
hugomrdias force-pushed the hugomrdias/remove-piece-metadata-getters branch from 974a475 to 3148c15 Compare August 26, 2026 11:34
@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@filoz/synapse-core@936
npm i https://pkg.pr.new/@filoz/synapse-react@936
npm i https://pkg.pr.new/@filoz/synapse-sdk@936

commit: a6b66bd

@hugomrdias hugomrdias changed the title Remove piece metadata getters from the SDK feat!: remove piece metadata getters Aug 26, 2026
@hugomrdias
hugomrdias merged commit 8e0ee82 into master Aug 26, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Piece metadata stops being accessible on-chain

5 participants