[FILECOIN V3] Improve hero images placement #2057
Open
+113
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-uxit
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-site
CharlyMartin
force-pushed
the
cm/update-hero-images-positions
branch
from
35004a7 to
a3f061c
Compare
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-site
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-uxit
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-uxit
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-site
Collaborator
|
Not sure why this is happening? CleanShot.2025-12-18.at.11.40.33.mp4 |
Collaborator
|
These paddings seem to big for mobile? 
|
apps/filecoin-site/src/app/[locale]/build-on-filecoin/components/HeroSection.tsx
Outdated
Show resolved
Hide resolved
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-site
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-uxit
Collaborator
Author
These are the default paddings for |
mirhamasala
reviewed
Dec 19, 2025
| </head> | ||
| <body className="bg-white font-sans text-base/5.5"> | ||
| <main>{children}</main> | ||
| <main className="overflow-x-hidden">{children}</main> |
Collaborator
There was a problem hiding this comment.
Uf .. feeling queazy about adding this to the the SiteLayout - Must we add this so high up?
Collaborator
Author
There was a problem hiding this comment.
The other option would be to add it to PageSection, which is used everywhere. It needs to be added to a full-width component, so we don't have that many options.
What worries you here?
mirhamasala
changed the title
mirhamasala
reviewed
Dec 19, 2025
apps/filecoin-site/src/app/[locale]/build-on-filecoin/components/HeroSection.tsx
Outdated
Show resolved
Hide resolved
…ts/HeroSection.tsx
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-site
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-uxit
mirhamasala
reviewed
Dec 19, 2025
Collaborator
mirhamasala
left a comment
mirhamasala
left a comment
There was a problem hiding this comment.
@CharlyMartin This all looks great! I do find this change a tiny bit aggressive and worrisome it might bite us. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR refactors the hero sections on the Build on Filecoin and Provide Storage pages.
🛠️ Key Changes
HeroSectioncomponent in../apps/filecoin-site/src/app/[locale]/build-on-filecoin/components/HeroSection.tsxto encapsulate header content and announcement section../apps/filecoin-site/src/app/[locale]/build-on-filecoin/page.tsxto use the newHeroSectioncomponent, removing inline header codeGradientOverlaycomponent in../apps/filecoin-site/src/app/_components/GradientOverlay.tsxto support three variants:to-bottom,to-top, anddual../packages/ui-filecoin/src/styles/button.cssto add explicit background colors for light and dark section variants📸 Screenshots