-
Notifications
You must be signed in to change notification settings - Fork 3
fix: add tooltip, misc bug fixes, a11y fixes #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joannaong
wants to merge
29
commits into
develop
Choose a base branch
from
feat/tooltip
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
4675a77
feat: tooltip
joannaong e608c06
feat: tooltip
joannaong d8d8841
feat: tooltip
joannaong 8b7b40b
fix: breadcrumb should not show in 404
joannaong 9187089
fix: tooltip positioning on desktop nav
joannaong 2bbf601
Merge branch 'develop' of https://github.com/data-preservation-progra…
joannaong 478bd3d
feat: mobile tooltip in progress
joannaong 997655d
fix: mobile cid card styling
joannaong 8ad38be
fix: styling for cid cards
joannaong 4eb3fc3
feat: add mock feature flag
joannaong 98353c6
fix: about page
joannaong f196bcd
fix: add back card-list-block
joannaong df1a780
Merge branch 'develop' of github.com:data-preservation-programs/open-…
timelytree fcbef17
fix: move id page copy to json, minor fixes
joannaong f6cfe69
fix: abstract tooltip
joannaong 54625da
fix: focus on logo
joannaong f967727
fix: button and focus-visible
joannaong 0bc0d00
fix: copy to content
joannaong 4724f3d
merge develop
joannaong c5ef30b
fix: inspect url
joannaong 15a0429
feat: tooltip module
joannaong ef95b8e
feat: add focus ring on category and see all / less toggle
joannaong 5a1accf
fix: hover selected filter button
joannaong 0bb09c0
merge dev
joannaong 0b3b7eb
fix: hover selected button filter
joannaong 66f6136
fix: filter button, focus visible
joannaong 273e666
feat: truncate mixin
joannaong b3df0ec
fix: styling on cid card
joannaong d3782ba
fix: tooltip mobile error
joannaong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
<template> | ||
<div :class="['card-list-block', `type__${cardType}`]"> | ||
<div :class="['card-list', direction]"> | ||
|
||
<template v-for="(card, i) in cards"> | ||
<component | ||
:is="cardComponent" | ||
:key="`card-${i}`" | ||
:index="i + 1" | ||
:card="card" | ||
class="card" /> | ||
</template> | ||
|
||
</div> | ||
</div> | ||
</template> | ||
|
||
<script> | ||
// ====================================================================== Import | ||
import FAQCard from '@/components/faq-card' | ||
|
||
// ====================================================================== Export | ||
export default { | ||
name: 'CardListBlock', | ||
|
||
components: { | ||
FAQCard | ||
}, | ||
|
||
props: { | ||
block: { | ||
type: Object, | ||
required: true, | ||
default: () => ({}) | ||
} | ||
}, | ||
|
||
computed: { | ||
cardType () { | ||
return this.block.card_type | ||
}, | ||
direction () { | ||
return ['row', 'column', 'row-reverse', 'column-reverse'].includes(this.block.direction) ? this.block.direction : 'row' | ||
}, | ||
cardComponent () { | ||
switch (this.cardType) { | ||
case 'faq': return 'FAQCard' | ||
default : return 'FAQCard' | ||
} | ||
}, | ||
cards () { | ||
return this.block.cards | ||
} | ||
} | ||
} | ||
</script> | ||
|
||
<style lang="scss" scoped> | ||
// ///////////////////////////////////////////////////////////////////// General | ||
.card-list { | ||
display: flex; | ||
&.row { | ||
flex-direction: row; | ||
} | ||
&.column { | ||
flex-direction: column; | ||
} | ||
&.row-reverse { | ||
flex-direction: row-reverse; | ||
} | ||
&.column-reverse { | ||
flex-direction: column-reverse; | ||
} | ||
} | ||
</style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.