[backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404) (#1837)

.github/agents/api-test-writer.agent.md

@@ -0,0 +1,27 @@
+---
+description: API test writer agent.
+tools: ['insert_edit_into_file', 'replace_string_in_file', 'create_file', 'run_in_terminal', 'get_terminal_output', 'get_errors', 'show_content', 'open_file', 'list_dir', 'read_file', 'file_search', 'grep_search', 'validate_cves', 'run_subagent', 'semantic_search']
+---
+You are a senior backend integration test engineer for the XTM Hub monorepo. You have deep expertise in designing robust, maintainable integration tests for API and backend systems, with a strong focus on real-world data flows and best practices.
+
+Follow these principles:
+Write tests in TypeScript using Vitest.
+Prefer real database calls over mocks for all *.domain.ts files. Only use mocks for external services or when testing *.app.ts files, and only when necessary.
+If you need to mock, do so only for external dependencies (e.g., MinIO, Elasticsearch).
+Keep tests simple, clear, and focused on real data flows.
+Use the actual database (test DB) for integration tests. Clean up data between tests to ensure isolation.
+Never use console.log; use logApp if logging is needed.
+Prefix unused variables with _ (underscore).
+Follow the repository’s structure and conventions for test files and setup/teardown.
+Use the project’s constants and helpers for test data (e.g., from tests/tests.const).
+Ensure tests are deterministic and do not depend on external state.
+Do not write frontend or UI tests.
+Ask for clarification if requirements or behaviors are ambiguous.
+
+As a senior engineer, you are expected to:
+Apply best practices for integration testing, code organization, and maintainability.
+Proactively identify edge cases and ensure comprehensive coverage.
+Document your tests clearly and concisely.
+Mentor by example through code quality and structure.
+
+Your goal: Write integration tests that validate the real behavior of backend modules, ensuring correctness, reliability, and maintainability at a high professional standard.

apps/portal-api/package.json

@@ -97,6 +97,7 @@
     "@types/config": "3.3.5",
     "@types/cors": "2.8.19",
     "@types/express-session": "1.18.2",
+    "@types/graphql-upload": "17.0.0",
     "@types/node": "24.10.13",
     "@types/nodemailer": "6.4.23",
     "@types/passport": "1.0.17",

apps/portal-api/src/migrations/20260305082651_mark-connector-pictures-external.js

@@ -0,0 +1,39 @@
+const loadConnectorChildImageIds = async (knex) => {
+  const parentConnectorIds = await knex('Document_Metadata')
+    .where({ key: 'integration_type', value: 'connector' })
+    .pluck('document_id');
+
+  if (!parentConnectorIds.length) return [];
+
+  const childImageIds = await knex('Document_Children')
+    .leftJoin('Document', 'Document_Children.child_document_id', 'Document.id')
+    .whereIn('Document_Children.parent_document_id', parentConnectorIds)
+    .andWhere('Document.type', 'image')
+    .pluck('Document.id');
+
+  return childImageIds;
+};
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+export const up = async (knex) => {
+  const childImageIds = await loadConnectorChildImageIds(knex);
+
+  await knex('Document')
+    .whereIn('id', childImageIds)
+    .update({ source_type: 'external' });
+};
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+export const down = async (knex) => {
+  const childImageIds = await loadConnectorChildImageIds(knex);
+
+  await knex('Document')
+    .whereIn('id', childImageIds)
+    .update({ source_type: 'internal' });
+};

apps/portal-api/src/modules/ingest-manifest/ingest-manifest.domain.ts

@@ -19,7 +19,7 @@ export const upsertConnectors = async (manifestInfo: ManifestInformation[]) => {
         connector.logo,
         `${connector.name}-logo.png`
       );
-      const doc = await DocumentApp.upsertDocument<Connector>(
+      const doc = await DocumentApp.upsertDocumentWithExternalImage<Connector>(
         OPENCTI_INTEGRATION_DOCUMENT_TYPE,
         { ...omit(connector, ['logo']) } as Connector,
         uploadLogo,

apps/portal-api/src/modules/ingest-manifest/ingest-manifest.helper.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest';
 import {
+  DocumentSourceType,
   IntegrationSubType,
   IntegrationType,
 } from '../../__generated__/resolvers-types';
@@ -34,7 +35,7 @@ describe('Ingest manifest helper', () => {
           integration_type: IntegrationType.Connector,
           manager_supported: true,
           playbook_supported: false,
-          source_type: 'external',
+          source_type: DocumentSourceType.External,
           service_instance_id: '0f4aad4b-bdd6-4084-8b1f-82c9c66578cc',
         });
         expect(result.validContracts[1]).toEqual({
@@ -54,7 +55,7 @@ describe('Ingest manifest helper', () => {
           integration_type: IntegrationType.Connector,
           manager_supported: false,
           playbook_supported: true,
-          source_type: 'external',
+          source_type: DocumentSourceType.External,
           service_instance_id: '0f4aad4b-bdd6-4084-8b1f-82c9c66578cc',
         });
       });

apps/portal-api/src/modules/ingest-manifest/ingest-manifest.helper.ts

@@ -2,6 +2,7 @@ import { FileUpload } from 'graphql-upload/processRequest.mjs';
 import { Readable } from 'stream';
 import z from 'zod';
 import {
+  DocumentSourceType,
   IntegrationSubType,
   IntegrationType,
 } from '../../__generated__/resolvers-types';
@@ -103,7 +104,7 @@ export const extractManifestInformation = (
         slug: validContract.slug,
         service_instance_id: INTEGRATION_SERVICE_INSTANCE_ID,
         type: OPENCTI_INTEGRATION_DOCUMENT_TYPE,
-        source_type: 'external',
+        source_type: DocumentSourceType.External,
         /* Document metadata properties */
         container_image: validContract.container_image,
         product_version: manifestData.version,