Skip to content

[frontend] fix(trials): wrong logo size on the dropdown selection #1911#1942

Open
Julienger0 wants to merge 2 commits intodevelopmentfrom
issue/1911
Open

[frontend] fix(trials): wrong logo size on the dropdown selection #1911#1942
Julienger0 wants to merge 2 commits intodevelopmentfrom
issue/1911

Conversation

@Julienger0
Copy link

@Julienger0 Julienger0 commented Mar 23, 2026

Context

Briefly describe the purpose and context of this PR. Include relevant screenshots or screen recordings for the product team.

BEFORE:

Capture d’écran 2026-03-23 à 15 18 27

AFTER:

Capture d’écran 2026-03-23 à 15 15 34

How to test

Provide step-by-step instructions to test your changes. Include screenshots of your local testing results.

Related issues

  • Related to #issueNumber

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

@Julienger0 Julienger0 self-assigned this Mar 23, 2026
@Julienger0 Julienger0 changed the title [frontend]fix:Hub banner - wrong logo size on the dropdown selection [frontend]fix:Hub banner - wrong logo size on the dropdown selection #1911 Mar 23, 2026
@Julienger0 Julienger0 marked this pull request as draft March 23, 2026 14:14
@Julienger0 Julienger0 added the Filigran Team use to identify PR from the Filigran team label Mar 23, 2026
@Julienger0 Julienger0 marked this pull request as ready for review March 23, 2026 14:21
@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.68%. Comparing base (19f4e1a) to head (81c843f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1942   +/-   ##
============================================
  Coverage        35.68%   35.68%           
============================================
  Files              654      654           
  Lines            41428    41428           
  Branches          2395     2395           
============================================
  Hits             14784    14784           
  Misses           26396    26396           
  Partials           248      248           
Files with missing lines Coverage Δ
...-instances/banner/try-filigran-products-banner.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f4e1a...81c843f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
35 35 0 0 0 0 3m 34s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
35 0 0 23.4s

Suites

35 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 3.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 23.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 19.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 28.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 6.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/organization-switcher.spec.ts
        ✅ Should see registered platforms, subscriptions and trials
✅ 1 ❌ 0 ⏭️ 0 4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 2.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 5.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/streams.spec.ts
        ✅ Should add Stream
        ✅ Should delete Stream from the list
        ✅ Should delete Stream from the detailed page
✅ 3 ❌ 0 ⏭️ 0 20.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/taxii-feeds.spec.ts
        ✅ Should add TAXII Feed
        ✅ Should delete TAXII Feed from the list
        ✅ Should delete TAXII Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 19.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/third-party-integrations.spec.ts
        ✅ Should add Third Party Integration
        ✅ Should delete Third Party Integration from the list
        ✅ Should delete Third Party Integration from the detailed page
✅ 3 ❌ 0 ⏭️ 0 20.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 15.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/xtm-suite-roadmap.spec.ts
        ✅ Should allow Filigran user to perform a CRUD of an epic
        ✅ Should allow users that are not connected to view the xtm suite roadmap
        ✅ Should allow community user to view the xtm suite roadmap
✅ 3 ❌ 0 ⏭️ 0 14.9s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@Julienger0 Julienger0 enabled auto-merge (squash) March 24, 2026 07:12
@Julienger0 Julienger0 disabled auto-merge March 24, 2026 08:09
@jbanety jbanety changed the title [frontend]fix:Hub banner - wrong logo size on the dropdown selection #1911 [frontend] fix(Hub banner): wrong logo size on the dropdown selection #1911 Mar 24, 2026
@jbanety jbanety changed the title [frontend] fix(Hub banner): wrong logo size on the dropdown selection #1911 [frontend] fix(banner): wrong logo size on the dropdown selection #1911 Mar 24, 2026
@jbanety jbanety changed the title [frontend] fix(banner): wrong logo size on the dropdown selection #1911 [frontend] fix(trials): wrong logo size on the dropdown selection #1911 Mar 24, 2026
@Julienger0 Julienger0 added the needs feature env Indicate if the PR needs an associated feature environment label Mar 24, 2026
@Julienger0 Julienger0 linked an issue Mar 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filigran Team use to identify PR from the Filigran team needs feature env Indicate if the PR needs an associated feature environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hub banner - wrong logo size on the dropdown selection

2 participants