Add support for ML-DSA-44 log signatures - #85
Open
rgdd wants to merge 6 commits into
Open
Conversation
To avoid code duplication.
Mainly to test that ML-DSA-44 log keys are parsed correctly, but while at it I also added a few additional sanity checks wrt. log-list format. Worth noting that witnessctl is less opinionated and only requires vkey as a mandatory key. I nevertheless added all require keys in the test.
Only positive tests were included. Because the main purpose is to ensure that it works to add an ML-DSA-44 key with witnessctl, and to then also process an incoming checkpoint with an ML-DSA-44 log sig. There's no integration test for witnessctl pull-logs, but I think the unit test in the previous commit gets us close enough wrt. testing.
Contributor
Author
|
CC @FiloSottile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the tests (see commits), we've also tested this on glasklar's witness-g1 service which cosigns checkpoints from one log operator that sends ML-DSA-44 signatures. Seems to work as expected.