cleanup, rewrite and add features#3
Open
StanHash wants to merge 26 commits intoFireEmblemUniverse:masterfrom
Open
cleanup, rewrite and add features#3StanHash wants to merge 26 commits intoFireEmblemUniverse:masterfrom
StanHash wants to merge 26 commits intoFireEmblemUniverse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #1 and #2
New features (not including things from #1):
Main).X,Y,WidthandHeightmap change properties don't do anything anymore. Map change dimensions are now computed automatically from tile layout.IDmap change property now is optional. If not provided, will be assigned an unused id starting from 0 (useful for map changes that don't need known ids, such as villages, chests, doors...).Internally, the entire thing has been rewritten to be more friendly to modifying the output format and/or adding/changing handled properties.