-
Notifications
You must be signed in to change notification settings - Fork 0
Add AI SDK tests to nightly Next.js CI. #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| const firebaseApp = initializeApp(firebaseConfig); | ||
| result.initializeAppResult = OK; | ||
|
|
||
| const auth = getAuth(firebaseApp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we sign in with auth for this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. At first I didn't have a user signed in and at that time the AI call failed, so I added as user login and changed a few other things at the same time. Then the AI call worked.
I guess the changes to the"few other things" are what made it work, not signing in a user.
Long story short: removed the Auth sign in stuff. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's causing the changes in the yarn.lock files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nested yarn.lock file shouldn't be there anymore. It was an artifact from before I converted to a mono repo so it should have been removed.
The base yarn.lock file was updated becuase I cleared everything out to test the yarn install again and didn't think that the minor updates in the lock file were hurting anything. But I'll revert it to previous version so it doesn't complicate this PR.
js-sdk-framework-tests/nextjs/src/components/app_tests/ai/results_display.tsx
Extend the Next.js test suite to include the Firebase JS AI SDK.
Additionally, removed
js-sdk-framework-tests/next/yarn.lockas it's no longer needed.