Skip to content

Conversation

@DellaBitta
Copy link
Collaborator

@DellaBitta DellaBitta commented Jul 23, 2025

Extend the Next.js test suite to include the Firebase JS AI SDK.

Additionally, removed js-sdk-framework-tests/next/yarn.lock as it's no longer needed.

const firebaseApp = initializeApp(firebaseConfig);
result.initializeAppResult = OK;

const auth = getAuth(firebaseApp);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we sign in with auth for this test?

Copy link
Collaborator Author

@DellaBitta DellaBitta Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. At first I didn't have a user signed in and at that time the AI call failed, so I added as user login and changed a few other things at the same time. Then the AI call worked.

I guess the changes to the"few other things" are what made it work, not signing in a user.

Long story short: removed the Auth sign in stuff. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's causing the changes in the yarn.lock files?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested yarn.lock file shouldn't be there anymore. It was an artifact from before I converted to a mono repo so it should have been removed.

The base yarn.lock file was updated becuase I cleared everything out to test the yarn install again and didn't think that the minor updates in the lock file were hurting anything. But I'll revert it to previous version so it doesn't complicate this PR.

@DellaBitta DellaBitta requested a review from hsubox76 July 23, 2025 22:21
js-sdk-framework-tests/nextjs/src/components/app_tests/ai/results_display.tsx
@DellaBitta DellaBitta merged commit 859285d into main Jul 25, 2025
5 checks passed
@DellaBitta DellaBitta deleted the ddb-ai-nextjs-tests branch July 25, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants