Connect CfdpManager directly to ComQueue#10
Merged
pepepr08 merged 1 commit intocfdp_managerfrom Apr 10, 2026
Merged
Conversation
Willmac16
reviewed
Apr 10, 2026
| // Port mapping is the same from bufferAllocate -> dataOut -> dataReturnIn -> bufferDeallocate | ||
| FW_ASSERT(portNum < Cfdp::NumChannels, portNum, Cfdp::NumChannels); | ||
| this->bufferDeallocate_out(portNum, data); | ||
| this->bufferDeallocate_out(portNum, fwBuffer); |
There was a problem hiding this comment.
typically we only deallocate out to port 0, but work if you use the specific mapping all throughout
|
|
||
| // Shift PDU data forward to make room for descriptor | ||
| // Use memmove (not memcpy) since source and destination overlap | ||
| memmove(bufferData + descriptorSize, bufferData, static_cast<size_t>(pduSize)); |
There was a problem hiding this comment.
Is there are reason we can't offset the initial write, rather than memmove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Changes needed to connect CfdpManager directly to ComQueue.
Rationale
The packet descriptor now need to be handled at the component side, to avoid the need for a Cfdp ComQueue Adapter.