Conversation
This reverts commit f48314f.
… NAK processed logic
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Can you do a pass to make sure that there's no diff where there doesn't need to be?
There was a problem hiding this comment.
@Brian-Campuzano Any chance you remember why it was needed to fix the comment offsets? 2668bab
There was a problem hiding this comment.
Pretty sure it was just the inconsistency triggering my OCD.
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
...because another more general variant is also in expect.
|
There is a CFDP directory here that we don't touch in this PR. It can be confusing for people to find CfdpManager elsewhere. I'm not saying we added CfdpManager to the wrong place, but is there anything we can do to avoid this confusion? |
I agree that it is confusing, however I was unable to move the checksum sub-directory into CFDP manager as it is used in the Framework FilePacket. One potential long term solution would be to move the checksum utility class into a framework folder. In the interim we could add a README.md file to the CFDP folder explaining its usecases. |
There was a problem hiding this comment.
Pretty sure it was just the inconsistency triggering my OCD.
There was a problem hiding this comment.
@pepepr08 does this need to be updated based on your ComQueue integration updates?
| | Name | Type | Port Type | Description | | ||
| |------|------|-----------|-------------| | ||
| | dataOut | output array[N] | `Fw.BufferSend` | Send encoded CFDP PDU data buffers to downstream components. One port (`N`) per CFDP channel. | | ||
| | dataReturnIn | async input array[N] | `Svc.ComDataWithContext` | Receive buffers previously sent via `dataOut` after downstream processing is complete. One port per CFDP channel. | |
There was a problem hiding this comment.
Does this need to be updated for the ComQueue integration updates?
|
I have also reviewed the changes in 6634aac |
4 participants
Change Description
This change adds CfdpManager, a component that provides CFDP support to Fprime for acknowledged file transfers.
Rationale
CCSDS File Delivery Protocol provides class 2, acknowledged transactions with guaranteed delivery.
Testing/Review Recommendations
Future Work
AI Usage (see policy)