Add arg names to header and valid#12
Open
Lex-ari wants to merge 20 commits intoLex-ari-CmdSeqIn-argsfrom
Open
Conversation
zimri-leisher
suggested changes
Apr 17, 2026
Lex-ari
force-pushed
the
Lex-ari-Validate-Arg-Names
branch
from
525bb7b to
31282aa
Compare
| Fw::SerializeStatus::FW_SERIALIZE_OK); | ||
| } | ||
| // write some statements | ||
| // write some statements (no arg mappings in body anymore, arg_specs are separate) |
There was a problem hiding this comment.
shouldn't the readBody test test reading arg specs though??
There was a problem hiding this comment.
i think you could probably keep most of the previous tests in this TEST_F and modify them for the new system
zimri-leisher
suggested changes
Apr 23, 2026
Lex-ari
force-pushed
the
Lex-ari-CmdSeqIn-args
branch
from
56d2fea to
d86b54d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Rationale
Testing/Review Recommendations
Future Work
AI Usage (see policy)