Add CFDP Telemetry#4
Merged
pepepr08 merged 1 commit intocfdp_managerfrom Mar 27, 2026
Merged
Conversation
0c01291 to
0515ab4
Compare
Merged
09a43d7 to
ba03ecf
Compare
ba03ecf to
d9f8288
Compare
Collaborator
Author
|
We will merge this in favor of keep making progress and have an easier integration later on. This code is being merged to the intermediate cfdp_manager branch, and will be reviewed anyway when we do a larger review of the cfdp component as a whole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
We have removed the old commented out telemetry code from CF app and added the equivalent Fprime telemetry. Unit tests for existing cases now include telemetry verification.
Rationale
Implement telemetry counters.
Testing/Review Recommendations
Unit tests for existing cases
Future Work
Negative cases to be added in second round of unit test updates.