Silverstripe 5 compatibility #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firesphere
requested changes
Oct 10, 2023
| use SilverStripe\Core\Injector\Injectable; | ||
| use SilverStripe\Security\Authenticator; | ||
|
|
||
| class CustomAuthenticatorRegistry |
There was a problem hiding this comment.
The name "CustomAuthenticatorRegistry" is too generic, a more descriptive and/or concise naming
| } | ||
|
|
||
| Security::setCurrentUser(null); | ||
| // We don't take any action here. |
There was a problem hiding this comment.
Then the token stays valid, which is even worse than logging out from everywhere...
| { | ||
| $response = Resolver::resolveCreateToken( | ||
| null, | ||
| ['email' => '[email protected]', 'password' => 'error'] |
There was a problem hiding this comment.
Test addresses should be example.com
| ['Email' => '[email protected]', 'Password' => 'error'], | ||
| [], | ||
| new ResolveInfo([]) | ||
| ['email' => '[email protected]', 'password' => 'error'], |
There was a problem hiding this comment.
Example.com instead of a functional domain
| ['Email' => '[email protected]', 'Password' => 'error'], | ||
| [], | ||
| new ResolveInfo([]) | ||
| ['email' => '[email protected]', 'password' => 'error'] |
There was a problem hiding this comment.
Same for this email. Example.com
| ['Email' => '[email protected]', 'Password' => 'error'], | ||
| [], | ||
| new ResolveInfo([]) | ||
| ['email' => '[email protected]', 'password' => 'error'] |
| ['Email' => '[email protected]', 'Password' => 'error'], | ||
| [], | ||
| new ResolveInfo([]) | ||
| ['email' => '[email protected]', 'password' => 'error'] |
| ['Email' => '[email protected]', 'Password' => 'error'], | ||
| [], | ||
| new ResolveInfo([]) | ||
| ['email' => '[email protected]', 'password' => 'error'] |
| ['Email' => '[email protected]', 'Password' => 'error'], | ||
| [], | ||
| new ResolveInfo([]) | ||
| ['email' => '[email protected]', 'password' => 'error'] |
There was a problem hiding this comment.
And the final one. example.com should be used in test/demoes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the module to work with Silverstripe 5; it's built upon Unclecheese's work.