Feat/add atd workflow facades#1417
Closed
rpogula2014 wants to merge 2 commits into
Closed
Conversation
Initial commit of the ATD adoption track on top of upstream v1.6.0 (additive only — no engine changes): - schemas/atd-sdlc: full pipeline ticket → analysis → (specs, design) → solution-doc → tasks; Jira/Confluence intake with grilling protocol, branch-alignment suggestion, confirmed idempotent write-back, code-as-truth analysis (SHA + file:line), AC traceability, scaled solution document, mandatory final task group (standards conformance, reconciliation, publication, Jira closure) - schemas/atd-sdlc-lite: three-artifact pipeline for low-risk corrections; semantically-gated triage sidecar (all-pass + lite recommendation + lite choice), embedded canonical 13-condition eligibility table, one-way escalation incl. late escalation via tasks.lite.md - atd-change-triage workflow (skill + /opsx:atd-triage command) in CORE_WORKFLOWS; registered across all enumerating surfaces incl. tool-detection - docs/atd: config template, standards-store conventions, lite-eligibility table, adoption track with pilot metrics, bootstrap - OpenSpec changes: add-atd-sdlc-schema and add-atd-sdlc-lite-triage (implemented), add-atd-docs-site and add-atd-workflow-facades (proposed) - tests: schema resolution/gates, instruction contracts, cross-surface condition-list parity (normalized ordered comparison), escalation status, instruction assembly with rules/references, triage-only detection — full suite 2095 passing External prerequisite: atd-standards store (placeholder seeded from the atd-angular skill; angular real, other three stacks pending stack leads).
Add atd-continue, atd-apply, atd-verify, and atd-close as thin façades over the generic continue/apply/verify/archive workflows, composed from new shared parameterized instruction-body builders (generic output stays byte-for-byte identical, locked by snapshots). Each façade names its journey position, embeds the shared ATD schema guard (atd-sdlc / atd-sdlc-lite only), and hands off to the next step; close hard-gates on apply state "all_done" with no override, states the delta-spec merge procedure inline, and never performs closure work itself. Recompose CORE_WORKFLOWS as the five ATD workflows plus explore and update; generic ids stay available via the custom profile. Register the façades across every enumerating surface, add a registry-parity test so an omission fails CI, map atd command→skill references for skills-only delivery, reuse the exported WORKFLOW_TO_SKILL_DIR in init (fixes stale local copy leaving façade skills behind on delivery switch), and point init/update onboarding at /opsx:atd-triage. Regenerate the committed skills/ distribution (17 skills). Implements openspec/changes/add-atd-workflow-facades (18/18 tasks).
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (79)
📝 WalkthroughWalkthroughThe PR adds ATD full and lite schemas, introduces a five-step ATD workflow façade journey, changes the default core profile, wires skill and command generation, adds strict close gating, and expands documentation and test coverage. ChangesATD workflow and schema rollout
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant Triage
participant OpenSpec
participant Apply
participant Verify
participant Close
Developer->>Triage: Provide Jira ticket and repository context
Triage->>OpenSpec: Create change with selected ATD schema
OpenSpec-->>Developer: Return change path and artifact status
Developer->>OpenSpec: Generate planning artifacts
Developer->>Apply: Execute tracked tasks and standards checks
Apply->>Verify: Hand off after all tracked tasks complete
Verify->>Close: Hand off after verification report
Close->>OpenSpec: Check apply state and synchronize deltas
OpenSpec-->>Close: Return all_done state and archive paths
Possibly related issues
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)docs/atd/config-template.yamlTraceback (most recent call last): openspec/changes/add-atd-docs-site/.openspec.yamlTraceback (most recent call last): openspec/changes/add-atd-sdlc-lite-triage/.openspec.yamlTraceback (most recent call last):
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation