Skip to content

Support init message #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

derom
Copy link

@derom derom commented Feb 14, 2020

Hey! First of all, thanks for this repo.
It would be nice to have the ability to send a message to websocket server. For example, subscribe to a specific channel of messages before starting a test.

@derom derom requested a review from Fitblip February 14, 2020 10:42
@coveralls
Copy link

coveralls commented Feb 14, 2020

Coverage Status

Coverage decreased (-0.01%) to 75.915% when pulling 83dd683 on derom:support-init-message into f7c91eb on Fitblip:master.

@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #19 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   75.92%   75.91%   -0.02%     
==========================================
  Files           5        5              
  Lines         324      328       +4     
==========================================
+ Hits          246      249       +3     
- Misses         78       79       +1
Impacted Files Coverage Δ
wsstat/main.py 91.66% <100%> (+0.36%) ⬆️
wsstat/clients.py 70.58% <66.66%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c91eb...83dd683. Read the comment docs.

@derom
Copy link
Author

derom commented Feb 14, 2020

There is no "WebSocket connection is closed" anymore python-websockets/websockets@8d907e0#diff-edaffe2a8ed181f48999c520ad93d60cL17
so I changed the expected message

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@f7c91eb). Learn more about missing BASE report.

Files Patch % Lines
wsstat/clients.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   75.91%           
=========================================
  Files             ?        5           
  Lines             ?      328           
  Branches          ?        0           
=========================================
  Hits              ?      249           
  Misses            ?       79           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants