fix: enable follow_redirects for httpx client to handle 307 status codes #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added follow_redirects=True to httpx.AsyncClient configuration - This resolves issues with 307 Temporary Redirect responses - Ensures proper handling of redirect responses from Flagsmith API - All existing tests continue to pass
gagantrivedi
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The httpx client was not configured to follow redirects, which caused issues when the Flagsmith API returned 307 Temporary Redirect responses.
Solution
Added
follow_redirects=Trueto the httpx.AsyncClient configuration insrc/edge_proxy/server.py.Changes
src/edge_proxy/server.pyto enable redirect followingTesting
Impact
This change ensures proper handling of redirect responses from the Flagsmith API, improving reliability when the API returns 307 status codes.