Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Sep 24, 2025

No description provided.

@khvn26 khvn26 requested a review from a team as a code owner September 24, 2025 08:53
@khvn26 khvn26 requested review from Zaimwa9 and removed request for a team September 24, 2025 08:53
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khvn26 I'm surprised to see no test for this?

@khvn26
Copy link
Member Author

khvn26 commented Sep 24, 2025

@matthewelwell Added a test in 0b378a8.

Co-authored-by: Matthew Elwell <[email protected]>
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve this with the minor change, but I'd only have to approve it again after you push the change... All good for me once we remove the unnecessary settings.

Co-authored-by: Matthew Elwell <[email protected]>
@khvn26 khvn26 merged commit c105be6 into main Sep 24, 2025
2 checks passed
@khvn26 khvn26 deleted the fix/deleted-identity-overrides-not-synced branch September 24, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants