Skip to content

chore: update docker proxy URL #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

matthewelwell
Copy link
Contributor

Changes

Sibling PR to Flagsmith/flagsmith#5255.

Update docker proxy URL to flagsmith.com domain to give us more control. Also completes the switch from scarf to reo. dev.

How did you test this code?

Verified that the following commands worked

# Pull a public image
docker pull docker.flagsmith.com/flagsmith/flagsmith

# Login via dockerhub credentials
docker login docker.flagsmith.com

# Pull a private image
docker pull docker.flagsmith.com/flagsmith/flagsmith-private-cloud

@matthewelwell matthewelwell requested a review from a team as a code owner March 27, 2025 12:10
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team March 27, 2025 12:10
@rolodato rolodato enabled auto-merge April 17, 2025 00:26
@matthewelwell matthewelwell force-pushed the chore/update-docker-proxy-url branch 2 times, most recently from 6a13326 to 8c0c9e2 Compare April 29, 2025 15:19
@matthewelwell
Copy link
Contributor Author

So, the 'Lint & Test' workflow is failing (due to a timeout) on this PR, but I can't work out why.

I originally assumed that it was related to an issue with github accessing docker.flagsmith.com, but it seems not to be the case since the test workflow I added to prove that images from docker.flagsmith.com can be pulled in a github action here worked (well, at least the docker pull did). I also think that I'm overriding the repository URL as per the change in this commit to charts/flagsmith/ci/e2e-test-values.yaml.

So, I'm pretty stumped here.

@matthewelwell matthewelwell disabled auto-merge April 29, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants