Skip to content

fix: Prevent identity fetch when traits and identity are undefined #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Prevent identity fetch when traits and identity are undefined #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1edc579
Prevent identity fetch when traits and identity are undefined
kyle-ssg Mar 28, 2025
3d303d9
Revert typescript package upgrade
kyle-ssg Mar 28, 2025
5967ee0
Revert comment
kyle-ssg Mar 28, 2025
41a23ab
Revert line break
kyle-ssg Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "flagsmith-cli",
"version": "0.2.1",
"version": "0.2.2",
"description": "A CLI allowing you to fetch Flagsmith flags and output them to a file",
"author": "kyle-ssg @kyle-ssg",
"bin": {
Expand Down
12 changes: 8 additions & 4 deletions src/commands/get/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,14 @@ export default class FlagsmithGet extends Command {
outputString += ` for identity ${identity}`
}

const traits : Record<string, string> = {}
for (const t of flags.trait || []) {
const [k, v] = t.split(/=(.*)/s)
traits[k] = v
let traits : Record<string, string> | undefined = undefined

if(flags.trait) {
traits = {}
for (const t of flags.trait || []) {
const [k, v] = t.split(/=(.*)/s)
traits[k] = v
}
}

const output = flags.output
Expand Down