fix: worker thread getting stuck #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TaskRunner threads were appearing "dead" and unable to process new tasks after some tasks timed out. This occurred because the ThreadPoolExecutor's context manager was blocking indefinitely when tasks exceeded their
timeout but continued running.
Root Cause
When a task times out in _run_task():
Over time, all 12 TaskRunner threads would get stuck, causing task processing to halt completely.
Solution
Changed from using the ThreadPoolExecutor context manager to explicit executor management with shutdown(wait=False):
Before:
After:
With shutdown(wait=False), the TaskRunner thread returns immediately after the timeout, allowing it to continue processing other tasks.
Changes
Why Existing Tests Didn't Catch This
Existing timeout tests use tasks that sleep for 1 second. While they timeout correctly, the 1-second blocking period is imperceptible. The bug only becomes apparent with longer-running tasks (10+ seconds), as seen
in production with S3 streaming tasks.