fix: reduce sleep time in timeout tests and add elapsed time checks #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gagantrivedi
commented
Oct 31, 2025
gagantrivedi
commented
- Changed sleep duration from 1000s (16 minutes) to 10s in both timeout tests
- Added elapsed time assertions to verify tests complete within 2 seconds
- Prevents CI jobs from hanging due to background threads sleeping for too long
- Ensures tests verify that the calling thread returns immediately after timeout
- Changed sleep duration from 1000s (16 minutes) to 10s in both timeout tests - Added elapsed time assertions to verify tests complete within 2 seconds - Prevents CI jobs from hanging due to background threads sleeping for too long - Ensures tests verify that the calling thread returns immediately after timeout
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 94.58% 94.59% +0.01%
==========================================
Files 75 75
Lines 2437 2443 +6
==========================================
+ Hits 2305 2311 +6
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewelwell
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.