fix: Ensure owning segment matches to parent segment from rule or condition #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
approved these changes
Dec 2, 2024
Comment on lines
+260
to
+261
| rule: models.Model, | ||
| segment: models.Model | None = None, |
There was a problem hiding this comment.
This is clearly out of the scope of this PR, but maybe we should define common abstract models in the flagsmith-common package.
There was a problem hiding this comment.
I'd be in favour of this.
Co-authored-by: Kim Gustyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes Flagsmith/flagsmith#4399
Presently the rules and conditions associated with a segment are not enforced to match the segment that they're included in. This PR enforces that the segments match by throwing a validation error.
Testing
Tests were done in the main repo in this PR.