Skip to content

fix: segment limit validation versioning #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: segment limit validation versioning #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb6829b
Update validation check for number of project segments
matthewelwell Dec 4, 2024
83d9a2c
Bump version
matthewelwell Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion common/segments/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,12 @@ def update(
return response

def validate_project_segment_limit(self, project: models.Model) -> None:
if project.segments.count() >= project.max_segments_allowed:
if (
apps.get_model("segments", "Segment")
.objects.filter(project=project)
.count()
>= project.max_segments_allowed
):
raise ValidationError(
{
"project": "The project has reached the maximum allowed segments limit."
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "flagsmith_common"
version = "0.1.0"
version = "1.4.1"
description = "A repository for including code that is required in multiple flagsmith repositories"
authors = ["Matthew Elwell <[email protected]>"]
readme = "README.md"
Expand Down
Loading