feat(utils): Allow for explicit use of database replicas #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents conflicts with other systems - Less unused code, yay
emyller
force-pushed
the
feat/new-database-replica-router
branch
from
18e8d28 to
e72f1e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 94.08% 94.51% +0.43%
==========================================
Files 73 75 +2
Lines 2232 2408 +176
==========================================
+ Hits 2100 2276 +176
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emyller
force-pushed
the
feat/new-database-replica-router
branch
from
e72f1e5 to
3e4ec91
Compare
emyller
force-pushed
the
feat/new-database-replica-router
branch
from
0713456 to
c4d1583
Compare
emyller
requested review from
gagantrivedi,
khvn26 and
matthewelwell
and removed request for
a team
emyller
changed the title
khvn26
reviewed
Sep 1, 2025
There was a problem hiding this comment.
Overall, looks great. Added a couple questions of moderate to low impact. Would like to see this tested in threaded Gunicorn to understand whether we need to use thread-local storage for the sequential replica cache. Besides that, interested to see if there's a performance effect on high-volume queries.
khvn26
reviewed
Sep 1, 2025
I'd be happy to do it given an example, and if it doesn't extend much of the scope here. |
khvn26
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith#5814.
This is meant to replace the
PrimaryReplicaRouterfunctionality in the core API.Changes
Introduces a utility
using_database_replicathat wraps any Django model manager binding it to a database replica according tosettings.REPLICA_READ_STRATEGY.Tests
Unit tests.