Skip to content

Commit 06afacc

Browse files
authored
fix: Analytics update is blocking (#156)
1 parent 469c085 commit 06afacc

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Flagsmith.FlagsmithClient/Flags.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@ public Flags(List<IFlag> flags, AnalyticsProcessor analyticsProcessor, Func<stri
2020
}
2121
public async Task<string> GetFeatureValue(string featureName) => (await GetFlag(featureName)).Value;
2222
public async Task<bool> IsFeatureEnabled(string featureName) => (await GetFlag(featureName)).Enabled;
23-
public async Task<IFlag> GetFlag(string featureName)
23+
public Task<IFlag> GetFlag(string featureName)
2424
{
2525
var flag = _Flags?.FirstOrDefault(f => f.GetFeatureName().Equals(featureName));
2626
if (flag == null)
2727
{
28-
return _DefaultFlagHandler?.Invoke(featureName) ?? throw new FlagsmithClientError("Feature does not exist: " + featureName);
28+
return Task.FromResult(_DefaultFlagHandler?.Invoke(featureName) ?? throw new FlagsmithClientError("Feature does not exist: " + featureName));
2929

3030
}
3131
if (_AnalyticsProcessor != null)
32-
await _AnalyticsProcessor.TrackFeature(flag.GetFeatureName()).ConfigureAwait(false);
33-
return flag;
32+
_ = _AnalyticsProcessor.TrackFeature(flag.GetFeatureName());
33+
return Task.FromResult(flag);
3434
}
3535
public List<IFlag> AllFlags() => _Flags;
3636
private static IFlag FromFeatureStateModel(FeatureStateModel featureStateModel, string identityId = null) =>

0 commit comments

Comments
 (0)