Skip to content

Conversation

@rolodato
Copy link
Contributor

I'm not sure how django_id can return null here, but other SDKs do handle this possibility:

This caused an exception in the FlagsmithClient constructor similar to this:

Newtonsoft.Json.JsonSerializationException

  HResult=0x80131500

  Message=Error converting value {null} to type 'System.Int32'. Path 'identity_overrides[0].identity_features[0].django_id', line 1, position 1372.

  Source=Newtonsoft.Json

  StackTrace:

   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType)

@matthewelwell matthewelwell merged commit 4a83292 into main Oct 30, 2024
10 checks passed
@matthewelwell matthewelwell deleted the fix/null-django-id-identity-override branch October 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants