ci: Fail publishing workflow if trying to release a duplicate version + bump to 6.0.0 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolodato
changed the title
|
I'm going to merge this and test by trying to publish 6.0.0 twice. |
khvn26
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow run was meant to publish version 6.0.0 and succeeded: https://github.com/Flagsmith/flagsmith-dotnet-client/actions/runs/12350235990/job/34462737804
However, the last published version is still 5.4.3: https://www.nuget.org/packages/Flagsmith. This is because we didn't bump the version here before releasing:
flagsmith-dotnet-client/Flagsmith.FlagsmithClient/Flagsmith.FlagsmithClient.csproj
Line 10 in 137590c
The workflow succeeded because it uses
dotnet nuget push --skip-duplicate. This is intended to handle partial failures when publishing multiple packages at once, which we don't want since we only have one package to publish.This change also bumps the version to 6.0.0.
Note: this is completely untested!