ci: fix release workflow #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
gagantrivedi
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue seen in release workflow here.
I'm not too sure why it started failing but I think it's similar to other recent issues (see e.g. #130, #132) where things have changed in the underlying system that mean certain built in dotnet versions are no longer available.
From what I can tell, we were trying to use 7.0.x on previous successful runs of the release workflow, but the library we're using to validate the package doesn't support 7.0.x so the only explanation is that it was falling back to some built in version of .net8.0.