Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 16, 2025

In this PR, we add support for generic feature metadata. Additionally, we

  • change the generic defaults to Mapping[str, object] from a Dict[str, object] to allow covariant values.
  • use EvaluationContext[Any, Any] in the interfaces that are not supposed to pass metadata further.

Review difficulty level: 2/5 due to sheer number of LoC changed.

@khvn26 khvn26 requested a review from a team as a code owner October 16, 2025 11:55
@khvn26 khvn26 requested review from emyller and removed request for a team October 16, 2025 11:55
@github-actions
Copy link

github-actions bot commented Oct 16, 2025

File Coverage Missing
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 4071832

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #269 will not alter performance

Comparing feat/feature-metadata (4071832) with main (07b1695)

Summary

✅ 1 untouched

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo, then good to go.

@khvn26 khvn26 requested a review from emyller October 16, 2025 19:13
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26 khvn26 merged commit bbb5be0 into main Oct 16, 2025
8 checks passed
@khvn26 khvn26 deleted the feat/feature-metadata branch October 16, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants