feat: Realtime improvements #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolodato
changed the title
* Don't panic in realtime * Retry fetching environment forever if cannot initialise * Use exponential backoff when reconnecting to SSE
rolodato
changed the title
gagantrivedi
requested changes
Mar 27, 2025
client.go
Outdated
|
|
||
| c.log.Info("environment updated", "environment", env.APIKey) | ||
| c.once.Do(func() { | ||
| if c.config.useRealtime && c.realtime == nil { |
There was a problem hiding this comment.
This should not be part of this method; UpdateEnvironment doesn't need to know anything about real-time
| for { | ||
| select { | ||
| case <-ticker.C: | ||
| if !pollForever { |
There was a problem hiding this comment.
This should be moved to real-time module/package; pollEnvironment should not be responsible for this
gagantrivedi
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WithPolling option
If
WithRealtimewas used, this also enables polling in the background. This lets us have polling as a fallback for SSERetry environment fetch on startup, don't panic in realtime
Instead of trying to fetch the environment document once and panicking from realtime if we couldn't, we now retry the initialisation indefinitely in a different goroutine. Once the environment initialises, we start the realtime connection as usual.
Retry SSE reconnections with exponential backoff + jitter
Used for error handling when SSE connection fails
Other features
slogWithSlogLoggeroption