Skip to content

fix: update engine test data v3.1.0 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix: update engine test data v3.1.0 #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flagengine/engine-test-data
Open in desktop
Submodule engine-test-data updated 156 files
10 changes: 8 additions & 2 deletions flagengine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ func getFlagResults(ec *engine_eval.EngineEvaluationContext, featureOverrides ma
// Get identity key if identity exists
var identityKey *string
if ec.Identity != nil {
identityKey = &ec.Identity.Key
// If identity key is not provided, construct it from environment key and identifier
if ec.Identity.Key == "" {
constructedKey := ec.Environment.Key + "_" + ec.Identity.Identifier
identityKey = &constructedKey
} else {
identityKey = &ec.Identity.Key
}
}

if ec.Features != nil {
Expand Down Expand Up @@ -147,7 +153,7 @@ func getFlagResultFromFeatureContext(featureName string, featureContext *engine_
cumulativeWeight += variant.Weight
if hashPercentage <= cumulativeWeight {
value = variant.Value
reason = fmt.Sprintf("SPLIT; weight=%.0f", variant.Weight)
reason = fmt.Sprintf("SPLIT; weight=%g", variant.Weight)
break
}
}
Expand Down
Loading