fix: error while adding flagsmith property to jira project #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant-shah-social
changed the title
matthewelwell
approved these changes
Aug 27, 2024
|
Thanks for this @nishant-shah-social . Could you fix up the formatting error here and we can get this merged and released. |
Done @matthewelwell |
|
Sorry @nishant-shah-social , not quite. You can see the necessary changes in the job failure here. |
matthewelwell
requested changes
Sep 5, 2024
matthewelwell
changed the base branch from
main
to
chore/fix-project-property-flagsmith
|
@nishant-shah-social I'm just going to merge this into a local branch and fix the linting myself. |
matthewelwell
merged commit 4613202
into
Flagsmith:chore/fix-project-property-flagsmith
1 check failed
Thanks @matthewelwell! My bad! Looks like that was the only permutation I didn't try 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While trying to setup flagsmith integration on the jira cloud instance, we faced an issue where-in an error was received while adding a flagsmith project in the jira project settings. Further debugging, we found that it gives an error
Unsupported media type 422while configuring flagsmith in the jira project settings.Looking at the documentation of jira v3 api, we found that the concerned PUT api call requires the content-type and Accept request headers which were missing. After adding these headers we were able to configure flagsmith for jira cloud successfully.
The PR is to address this problem.