Skip to content

Fix: typo in type definition file #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiagoapolo merged 2 commits into from
Apr 25, 2025
Merged

Fix: typo in type definition file #308

tiagoapolo merged 2 commits into from
Apr 25, 2025

Conversation

@benwilson34
Copy link
Contributor

@benwilson34 benwilson34 commented Apr 24, 2025

Closes #307

  • fix typos in type definition file and test file
  • add development details to readme and package.json

tiagoapolo
tiagoapolo approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@tiagoapolo tiagoapolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, can you please patch a version?
you'll need to update these files:

  • lib/flagsmith/package.json
  • lib/react-native-flagsmith/package.json

@benwilson34
Copy link
Contributor Author

benwilson34 commented Apr 25, 2025

That looks good to me, can you please patch a version? you'll need to update these files:

  • lib/flagsmith/package.json
  • lib/react-native-flagsmith/package.json

Updated - that look good?

@tiagoapolo tiagoapolo merged commit ad239e5 into Flagsmith:main Apr 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tiagoapolo tiagoapolo tiagoapolo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in IFlagsmithFeature type definition?

2 participants

@benwilson34 @tiagoapolo