feat: send user agent header #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazreese
requested review from
Zaimwa9,
emyller and
matthewelwell
and removed request for
a team
emyller
reviewed
Nov 3, 2025
There was a problem hiding this comment.
Is it possible to somehow mock the version so it can be seen in at least one test? All current tests only verify unknown is added in the header.
Comment on lines
+50
to
+60
| private fun getSdkVersion(): String { | ||
| return try { | ||
| // Try to get version from BuildConfig | ||
| val buildConfigClass = Class.forName("com.flagsmith.kotlin.BuildConfig") | ||
| val versionField = buildConfigClass.getField("VERSION_NAME") | ||
| versionField.get(null) as String | ||
| } catch (e: Exception) { | ||
| // Fallback to hardcoded version if BuildConfig is not available | ||
| "unknown" | ||
| } | ||
| } |
There was a problem hiding this comment.
Is the Android machinery used to obtain the Flagsmith client version more reliable than iOS'? I'm asking considering the equivalent pull request to iOS (Flagsmith/flagsmith-ios-client#95) falls back to a hardcoded version string when obtaining the lib version fails, and I wonder why the same strategy isn't used here as well. (I'm not asking we implement it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://foresight.slite.com/app/docs/vY7NnrbUCj35XE#ccb66bd3-d784-4e5d-bf6e-8559bb0a76d6
Previous review and subsequent fixes on the Foresight side: foresightmobile#1
Description
Added a User-Agent HTTP header to network calls. Uses the package's version at runtime, if it is not available sends it as "unknown"
Also added a PR template, once this merged new PRs will come with this PR template.
Regression Test Recommendations
Test that User-Agent header is present in all HTTP requests with correct format: flagsmith-swift-ios-sdk/
Test fallback to "unknown" when version is not discoverable at runtime
Validate User-Agent appears in both REST API calls and SSE connections
Type of Change
✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore
Summary by CodeRabbit
New Features
Adds a dynamic User-Agent header to network requests that reflects the SDK/app version when available.
Real-time updates initialization now accepts Android context for more reliable behavior on devices.
Tests
New unit tests validating User-Agent composition and that the header is sent across various request types and failure scenarios.