-
Notifications
You must be signed in to change notification settings - Fork 25
fix!: Improve error handling when environment fetch fails. Minor type safety breaking changes #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
reviewed
Mar 21, 2025
Co-authored-by: Kim Gustyr <[email protected]>
88ab0ac to
88b9176
Compare
Co-authored-by: Matthew Elwell <[email protected]>
matthewelwell
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #177, which is tested here: https://github.com/Flagsmith/flagsmith-nodejs-client/pull/178/files#diff-d51f632ca0e8d754d607e28740780bb82e314eb5b22dbba97edd8f2a7c7cb32cR344.
Breaking changes introduced in this PR:
this.environmentis typed as not null, but this is not true. This should never have been exposed, and now we have agetEnvironmentmethod that exposes a shared promise for the environment documentonEnvironmentChangehandlers can now be undefined, which happens if there was an error. If we failed to update the environment, it doesn't make sense to send the previous environment as part of this event.Flagsmithconstructor now throws an error if local evaluation is enabled but a server-side key was not used. Previously it would log an error and continueThis PR also makes it so that the test suite does not cause actual API calls to Flagsmith. All HTTP calls in tests are now mocked.
Other misc fixes:
environmentRefreshInterval: 0prevents polling from startinggetIdentityFlagsnow actually uses a default flag handler if provided, or fails if it needs to be called but is missing. Previously this would fail and not use the default handlerconsole.logandconsole.error, always use loggersNew features:
requestRetryDelayMillisecondsoption to make retry delay configurable, previously hardcoded at 1 second. This, with the default 3x retries, made some tests take at least 3 seconds to finish. Now, we do 0 retries and 0 delay in tests by default.