-
Notifications
You must be signed in to change notification settings - Fork 25
feat: implement context values #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the PR looks solid to me — just a handful of comments to address.
…t.types.ts Co-authored-by: Kim Gustyr <[email protected]>
…flagsmith-nodejs-client into feat/implement-context-values
flagsmith-engine/evaluation/evaluationResult/evaluationResult.types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close... just one comment from my side to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #198
In this PR, we:
EvaluationResult getEvaluationResult(EvaluationContext context)and remove all of the old engine APIs.evaluationContext/mappersfor engine-API data interopgenerate-engine-typesto generate fromflagsmith/sdk/evaluation-*-schema-> in pre-commitCouple of questions concerning:
hide_disabled_flagsdeprecation => ready to remove the commented codegetEnvironmentthat also includesgetEnvironmentFromApi. I'm not seeing a huge value to migrate it but maybe I am missing something ? this would getEnvironmentFlagsFromDocument/getIdentityFlagsFromDocument -> getEnvironment -> this.offlineHandler.getEnvironment -> getEvaluationContext (using environment)Happy to change if misunderstood