-
Notifications
You must be signed in to change notification settings - Fork 25
feat: implement context values #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zaimwa9
wants to merge
33
commits into
main
Choose a base branch
from
feat/implement-context-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,926
−448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaimwa9
commented
Sep 19, 2025
Zaimwa9
commented
Sep 19, 2025
Zaimwa9
commented
Sep 19, 2025
khvn26
reviewed
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the PR looks solid to me — just a handful of comments to address.
gagantrivedi
reviewed
Oct 3, 2025
gagantrivedi
previously approved these changes
Oct 6, 2025
gagantrivedi
requested changes
Oct 9, 2025
gagantrivedi
previously approved these changes
Oct 9, 2025
khvn26
reviewed
Oct 15, 2025
value: Value2; | ||
variants?: Variants; | ||
priority?: Priority; | ||
priority?: Priority1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
priority?: Priority1; | |
priority: Priority1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198
In this PR, we:
EvaluationResult getEvaluationResult(EvaluationContext context)
and remove all of the old engine APIs.evaluationContext/mappers
for engine-API data interopgenerate-engine-types
to generate fromflagsmith/sdk/evaluation-*-schema
-> in pre-commitCouple of questions concerning:
hide_disabled_flags
deprecation => ready to remove the commented codegetEnvironment
that also includesgetEnvironmentFromApi
. I'm not seeing a huge value to migrate it but maybe I am missing something ? this would getEnvironmentFlagsFromDocument/getIdentityFlagsFromDocument -> getEnvironment -> this.offlineHandler.getEnvironment -> getEvaluationContext (using environment)Happy to change if misunderstood