feat(Engine): Evaluate from EvaluationContext #108
+769
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyller
force-pushed
the
feat/context-values
branch
6 times, most recently
from
8a8c07a to
3f2eaf4
Compare
emyller
force-pushed
the
feat/context-values
branch
from
3f2eaf4 to
7295ca8
Compare
emyller
commented
Sep 25, 2025
emyller
commented
Sep 25, 2025
emyller
commented
Sep 25, 2025
emyller
force-pushed
the
feat/context-values
branch
from
38c5cef to
fe68922
Compare
Contributes to Flagsmith/flagsmith#6121
emyller
commented
Oct 1, 2025
emyller
force-pushed
the
feat/context-values
branch
from
4e231b6 to
cc6ae4c
Compare
khvn26
requested changes
Oct 2, 2025
There was a problem hiding this comment.
Looks great overall — just a handful of comments, some of them relevant to Flagsmith/engine-test-data#14.
gagantrivedi
requested changes
Oct 8, 2025
.gitmodules
Outdated
| path = tests/Engine/EngineTests/EngineTestData | ||
| url = [email protected]:Flagsmith/engine-test-data.git | ||
| branch = v1.0.0 | ||
| branch = feat/context-values |
There was a problem hiding this comment.
This should be updated to include the new tests
emyller
force-pushed
the
feat/context-values
branch
from
842a88f to
d9d977c
Compare
(cherry picked from commit 2913611)
emyller
force-pushed
the
feat/context-values
branch
from
fc10655 to
7d0d026
Compare
khvn26
approved these changes
Oct 14, 2025
khvn26
requested changes
Oct 14, 2025
There was a problem hiding this comment.
Sorry, one last comment: we need to implement https://github.com/Flagsmith/engine-test-data/pull/28/files.
emyller
force-pushed
the
feat/context-values
branch
from
0e5a777 to
acc06b3
Compare
Addressed in acc06b3. The client side also follows with 4145960. |
khvn26
reviewed
Oct 15, 2025
| path = tests/Engine/EngineTests/EngineTestData | ||
| url = [email protected]:Flagsmith/engine-test-data.git | ||
| branch = v1.0.0 | ||
| tag = v2.3.0 |
There was a problem hiding this comment.
Let's include the variant sorting tests:
Suggested change
| tag = v2.3.0 | |
| tag = v2.4.0 |
khvn26
reviewed
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Because we decided to break this project into smaller pieces only after work started, this branch will only see the engine changes.
Contributes to #98
This is pass 1 of 3.
get_evaluation_result+ engine tests passing. No deleted code. (this PR)The engine work is largely inspired by flagsmith-engine.
Note
Notes are added to call for discussion or follow up.