chore: Standardize engine metadata #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns Python client with other Flagsmith clients by renaming the metadata field used in client-engine communication from
flagsmith_idtoid. This change only affects internal metadata structures passed between client and engine—no impact on external APIs or evaluation logic.Changes
Type definitions (
flagsmith/types.py)SegmentMetadata.flagsmith_id→SegmentMetadata.idFeatureMetadata.flagsmith_id→FeatureMetadata.idMappers (
flagsmith/mappers.py)"flagsmith_id"to"id"flagsmith_idtofeature_idin identity overrides mappingModels (
flagsmith/models.py)Flag.from_evaluation_result()Tests
Example
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
test_urlanalytics/home/REDACTED/.cache/pypoetry/virtualenvs/flagsmith-K6knkhUn-py3.12/bin/python /home/REDACTED/.cache/pypoetry/virtualenvs/flagsmith-K6knkhUn-py3.12/bin/pytest tests/ -v --tb=short(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.