Merge pull request #68 from ForwardFinancing/allow-false-flag-values

zachaysan · web-flow · commit 3e0d42cdc4b4 · 2024-12-04T14:51:25.000-05:00
fix: allow false as a flag value
diff --git a/lib/flagsmith/sdk/models/flags.rb b/lib/flagsmith/sdk/models/flags.rb
@@ -71,7 +71,7 @@ def from_feature_state_model(feature_state_model, identity_id)
         def from_api(json_flag_data)
           new(
             enabled: json_flag_data[:enabled],
-            value: json_flag_data[:feature_state_value] || json_flag_data[:value],
+            value: json_flag_data.fetch(:feature_state_value) { json_flag_data[:value] },
             feature_name: json_flag_data.dig(:feature, :name),
             feature_id: json_flag_data.dig(:feature, :id)
           )

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ def from_feature_state_model(feature_state_model, identity_id)`
`71`	`71`	`def from_api(json_flag_data)`
`72`	`72`	`new(`
`73`	`73`	`enabled: json_flag_data[:enabled],`
`74`		`- value: json_flag_data[:feature_state_value] \|\| json_flag_data[:value],`
	`74`	`+ value: json_flag_data.fetch(:feature_state_value) { json_flag_data[:value] },`
`75`	`75`	`feature_name: json_flag_data.dig(:feature, :name),`
`76`	`76`	`feature_id: json_flag_data.dig(:feature, :id)`
`77`	`77`	`)`