feat: evaluation context mappers #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested changes
Oct 23, 2025
| module EvaluationContext | ||
| module Mappers | ||
| # Using integer constant instead of -Float::INFINITY because the JSON serializer rejects infinity values | ||
| HIGHEST_PRIORITY = 0 |
There was a problem hiding this comment.
Just for safety, I'd prefer this to be lower than 0. Also, our naming convention for these constants is strongest-weakest:
Suggested change
| HIGHEST_PRIORITY = 0 | |
| STRONGEST_PRIORITY = -99_999_999 |
| end | ||
|
|
||
| # Create hash of the overrides to group identities with same overrides | ||
| overrides_hash = Digest::SHA1.hexdigest(overrides_key.to_json) |
There was a problem hiding this comment.
Consider one of the following alternatives.
- Using
inspectinstead ofto_jsonmight be more performant, and doesn't require us to avoidInf:
Suggested change
| overrides_hash = Digest::SHA1.hexdigest(overrides_key.to_json) | |
| overrides_hash = Digest::SHA1.hexdigest(overrides_key.inspect) |
- I'm not too familiar with Ruby's
Object::hash, but it could be sufficient in our case. We could drop thedigestdependency that way:
Suggested change
| overrides_hash = Digest::SHA1.hexdigest(overrides_key.to_json) | |
| overrides_hash = overrides_key.hash |
There was a problem hiding this comment.
I'm actually reverting this change to inspect as I discovered that the hash is not consistent over application restarts
There was a problem hiding this comment.
We're not persisting this hash anywhere, so I don't think it's a requirement for it to be consistent across runtimes? Am I missing something?
Co-authored-by: Kim Gustyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Contributes to #81
This is pass 1 of 4.
map_environment_model_to_evaluation_context,map_identity_overrides_to_segments,map_segment_rule_to_model,map_identity_model_to_identity_context)How did you test this code?